Conversation
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
msgvault's Windows CLI and store tests now finish in about 16 and 8 minutes instead of 33 and 28.
Each job ran on one 4-core machine that was already full, so its test groups couldn't go faster. Spreading each across 3 machines cuts the wall time.
The extra machines don't slow other repos' CI, since over 3 days of org CI half of 14,115 jobs on GitHub's machines started within 2 seconds, and in the one burst where jobs waited, 170 of the 180 running were msgvault's own.
The shard script now takes a part number so each of 3 machines runs every third test, and the Windows matrix runs the CLI and store packages as three parts each.